docs(rfd): Session Config Options to Preview stage #378
+283
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With several implementations in place, it feels like this is ready for preview. I added this in Zed + Codex ACP, and the JetBrains folks have this in their Kotlin SDK. So let's move this to preview stage for final feedback!
| | `mode` | Session mode selector | | ||
| | `model` | Model selector | | ||
| | `thought_level` | Thought/reasoning level selector | | ||
| | `other` | Unknown or uncategorized selector (default) | |
Contributor
There was a problem hiding this comment.
Q: Can clients add other categories? Should we require that if clients opt for a "custom" category, it begins with _ for extensibility purposes?
Q: Can there be multiple categories? (presumably not)
Member
Author
There was a problem hiding this comment.
Good point. I do think this other could just be a string, with maybe some convention around _ or something
Contributor
There was a problem hiding this comment.
I would say something like: category names beginning with _ are free for others to use; category names that do not begin with _ are reserved for the ACP spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With several implementations in place, it feels like this is ready for preview.
I added this in Zed + Codex ACP, and the JetBrains folks have this in their Kotlin SDK. So let's move this to preview stage for final feedback!